From 64ecde05324501c64082facf271aa11c84fbf6db Mon Sep 17 00:00:00 2001
From: Eric Wong <eric@wsdjeg.net>
Date: Sun, 30 Jun 2024 19:13:24 +0800
Subject: [PATCH] perf(buf): open buf in best win

close https://github.com/SpaceVim/SpaceVim/issues/4888
---
 lua/spacevim/plugin/tabline.lua | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/lua/spacevim/plugin/tabline.lua b/lua/spacevim/plugin/tabline.lua
index e7bd508d5..56b66bdc3 100644
--- a/lua/spacevim/plugin/tabline.lua
+++ b/lua/spacevim/plugin/tabline.lua
@@ -33,6 +33,7 @@ local highlight = require('spacevim.api.vim.highlight')
 local file = require('spacevim.api.file')
 
 local messletters = require('spacevim.api.messletters')
+local WIN = require('spacevim.api.vim.window')
 
 local shown_items = {}
 
@@ -524,6 +525,30 @@ function M.def_colors()
   highlight.hi_separator('SpaceVim_tabline_m', 'SpaceVim_tabline_a')
 end
 
+local function is_best_win(winid)
+  local bufnr = vim.api.nvim_win_get_buf(winid)
+  local ft = vim.bo[bufnr].filetype
+  if ft == 'defx' or ft == 'nerdtree' or ft == 'tagbar' then
+    return false
+  end
+
+  return true
+end
+
+local function open_in_best_win(bufnr)
+  if is_best_win(vim.api.nvim_get_current_win()) then
+    vim.api.nvim_set_current_buf(bufnr)
+    return
+  end
+  for winnr = 1, vim.fn.winnr('$') do
+    local winid = vim.fn.win_getid(winnr)
+    if is_best_win(winid) and not WIN.is_float(winid) then
+      vim.api.nvim_set_current_win(winid)
+      vim.api.nvim_set_current_buf(bufnr)
+    end
+  end
+end
+
 function M.jump(id)
   if id == 'next' then
     if vim.fn.tabpagenr('$') > 1 then
@@ -569,7 +594,7 @@ function M.jump(id)
     if vim.fn.tabpagenr('$') > 1 then
       vim.cmd('tabnext' .. id)
     else
-      vim.api.nvim_set_current_buf(shown_items[id].bufnr)
+      open_in_best_win(shown_items[id].bufnr)
     end
   end
 end