diff --git a/autoload/SpaceVim/plugins/manager.vim b/autoload/SpaceVim/plugins/manager.vim index 4b7769ec7..fc2ef8776 100644 --- a/autoload/SpaceVim/plugins/manager.vim +++ b/autoload/SpaceVim/plugins/manager.vim @@ -550,10 +550,12 @@ function! s:open_plugin_dir() abort enew exe 'resize ' . &lines * 30 / 100 let shell = empty($SHELL) ? SpaceVim#api#import('system').isWindows ? 'cmd.exe' : 'bash' : $SHELL - if has('nvim') + if has('nvim') && exists('*termopen') call termopen(shell, {'cwd' : dein#get(keys(plugin)[0]).path}) - else + elseif exists('*term_start') call term_start(shell, {'curwin' : 1, 'term_finish' : 'close', 'cwd' : dein#get(keys(plugin)[0]).path}) + else + exe 'VimShell ' . dein#get(keys(plugin)[0]).path endif endif endfunction diff --git a/docs/cn/development.md b/docs/cn/development.md index 354051ad3..f01714b91 100644 --- a/docs/cn/development.md +++ b/docs/cn/development.md @@ -14,6 +14,7 @@ lang: cn - [证书](#证书) - [公约](#公约) - [拉取请求](#拉取请求) + - [PR 标题前缀](#pr-标题前缀) - [在上游的主分支顶部压缩你的PR分支](#在上游的主分支顶部压缩你的pr分支) - [抽象化的简单 PRs(绝大多数PRs都是这样的):](#抽象化的简单-prs绝大多数prs都是这样的) - [复杂的PRs (大的重构, 等):](#复杂的prs-大的重构-等) @@ -80,6 +81,21 @@ SpaceVim 建立在下面的公约上: 该公约主要包括了 函数的命名, ### 拉取请求 +#### PR 标题前缀 + +新开 pull request 时,应当标记该 PR 属于以下哪种前缀: + +- `Add:` 添加一新的特性 +- `Change:` 修改已有特性的行为 +- `Fixed:` 修复某些问题 +- `Remove:` 移除原先支持的某种特性 +- `Doc:` 更新帮助文档 +- `Website:` 更新网站内容 + +示例如下: + +`Website: update the lang#c layer page` + #### 在上游的主分支顶部压缩你的PR分支 - fork SpaceVim 仓库 diff --git a/docs/development.md b/docs/development.md index f05ea55fd..83b85cf23 100644 --- a/docs/development.md +++ b/docs/development.md @@ -91,6 +91,7 @@ pull request title should contains one of these prefix: - `Add:` Adding a new feature. - `Change:` Change default behaviors or the existing features. +- `Fixed:` Fix some bugs - `Remove:` Remove any existing features. - `Doc:` update the help file. - `Website:` Update the contend of website. diff --git a/wiki/en/Following-HEAD.md b/wiki/en/Following-HEAD.md index a9d471c86..bcc569d30 100644 --- a/wiki/en/Following-HEAD.md +++ b/wiki/en/Following-HEAD.md @@ -18,6 +18,10 @@ The next release is v0.9.0. - Change the option name `enable_statusline_display_mode` to `enable_statusline_mode` ([#1843](https://github.com/SpaceVim/SpaceVim/pull/1843)) - Recover spell and list option in go layer ([#1872](https://github.com/SpaceVim/SpaceVim/pull/1872)) +### Fixed + +- Fix plugins manager, unkown function `term_start` ([#1881](https://github.com/SpaceVim/SpaceVim/pull/1881)) + ### Removed ### Doc, Wiki && Website